Updating test framework reveals a bunch of failing tests
Closed this issue · 1 comments
liamsi commented
While playing with go modules, I realized that a bunch of tests started failing in #255
Note, this is not related to go modules at all! This is due to some outdated dependencies. Probably, testify/assert was buggy. dep ensure -update will expose the exact same failing tests.
Click below to expand which tests are failing:
make test
go test github.com/tendermint/go-amino github.com/tendermint/go-amino/cmd/aminoscan github.com/tendermint/go-amino/tests github.com/tendermint/go-amino/tests/fuzz/binary github.com/tendermint/go-amino/tests/fuzz/binary/debug github.com/tendermint/go-amino/tests/fuzz/binary/init-corpus github.com/tendermint/go-amino/tests/fuzz/json github.com/tendermint/go-amino/tests/fuzz/json/debug github.com/tendermint/go-amino/tests/proto3/proto
--- FAIL: TestUnmarshalMap (0.00s)
json_test.go:182:
Error Trace: json_test.go:182
json_test.go:180
Error: should have paniced but got err: %v
Test: TestUnmarshalMap
Messages: Not enough bytes to read in UnmarshalBinaryLengthPrefixed, want 100 more bytes but only have 7
json_test.go:180:
Error Trace: json_test.go:180
Error: func (assert.PanicTestFunc)(0x1351430) should panic
Panic value: <nil>
Test: TestUnmarshalMap
json_test.go:186:
Error Trace: json_test.go:186
json_test.go:184
Error: should have paniced but got err: %v
Test: TestUnmarshalMap
Messages: Not enough bytes to read in UnmarshalBinaryLengthPrefixed, want 100 more bytes but only have 7
json_test.go:184:
Error Trace: json_test.go:184
Error: func (assert.PanicTestFunc)(0x1351520) should panic
Panic value: <nil>
Test: TestUnmarshalMap
json_test.go:196:
Error Trace: json_test.go:196
json_test.go:194
Error: should have paniced but got err: %v
Test: TestUnmarshalMap
Messages: invalid character -- Amino:JSON int/int64/uint/uint64 expects quoted values for javascript numeric support, got: 2.
json_test.go:194:
Error Trace: json_test.go:194
Error: func (assert.PanicTestFunc)(0x1351740) should panic
Panic value: <nil>
Test: TestUnmarshalMap
json_test.go:200:
Error Trace: json_test.go:200
json_test.go:198
Error: should have paniced but got err: %v
Test: TestUnmarshalMap
Messages: invalid character -- Amino:JSON int/int64/uint/uint64 expects quoted values for javascript numeric support, got: 2.
json_test.go:198:
Error Trace: json_test.go:198
Error: func (assert.PanicTestFunc)(0x1351830) should panic
Panic value: <nil>
Test: TestUnmarshalMap
--- FAIL: TestUnmarshalFunc (0.00s)
json_test.go:217:
Error Trace: json_test.go:217
json_test.go:215
Error: should have paniced but got err: %v
Test: TestUnmarshalFunc
Messages: Not enough bytes to read in UnmarshalBinaryLengthPrefixed, want 100 more bytes but only have 7
json_test.go:215:
Error Trace: json_test.go:215
Error: func (assert.PanicTestFunc)(0x1351a60) should panic
Panic value: <nil>
Test: TestUnmarshalFunc
json_test.go:221:
Error Trace: json_test.go:221
json_test.go:219
Error: should have paniced but got err: %v
Test: TestUnmarshalFunc
Messages: Not enough bytes to read in UnmarshalBinaryLengthPrefixed, want 100 more bytes but only have 7
json_test.go:219:
Error Trace: json_test.go:219
Error: func (assert.PanicTestFunc)(0x1351b50) should panic
Panic value: <nil>
Test: TestUnmarshalFunc
json_test.go:235:
Error Trace: json_test.go:235
json_test.go:233
Error: should have paniced but got err: %v
Test: TestUnmarshalFunc
Messages: UnmarshalJSON expects a pointer
json_test.go:233:
Error Trace: json_test.go:233
Error: func (assert.PanicTestFunc)(0x1351e60) should panic
Panic value: <nil>
Test: TestUnmarshalFunc
FAIL
FAIL github.com/tendermint/go-amino 120.378s
? github.com/tendermint/go-amino/cmd/aminoscan [no test files]
? github.com/tendermint/go-amino/tests [no test files]
? github.com/tendermint/go-amino/tests/fuzz/binary [no test files]
? github.com/tendermint/go-amino/tests/fuzz/binary/debug [no test files]
? github.com/tendermint/go-amino/tests/fuzz/binary/init-corpus [no test files]
? github.com/tendermint/go-amino/tests/fuzz/json [no test files]
? github.com/tendermint/go-amino/tests/fuzz/json/debug [no test files]
? github.com/tendermint/go-amino/tests/proto3/proto [no test files]
make: *** [test] Error 1