tendermint/go-crypto

Proposal: minor API simplifications

Closed this issue · 3 comments

liamsi commented
  • remove error from privKey.PublicKey(), if one already has the priv. key in hand the pub-key should be derivable from that without erroring: resolved via #131
  • remove the Get* in front of the Info interface methods: "it's neither idiomatic nor necessary to put Get into the getter's name." https://golang.org/doc/effective_go.html?#Getters
cwgoes commented

Agreed on both counts. Need to make sure we store and cache the public key when creating a remote private key (e.g. on the Ledger device) to fulfill this API.

liamsi commented
  • error has been removed in #131
  • discussion regarding the getters should happen in cosmos-sdk
cwgoes commented

Moved to cosmos/cosmos-sdk#1518.

  • 👍1