bring back updates that broke tests
zramsay opened this issue · 3 comments
zramsay commented
see #26 and #27 cc @davebryson and @marypreethi12
Sorry I had to revert those changes, discovered broken tests (npm test
) while implementing the CI
davebryson commented
So essentially the fixture related tests are based on byte signatures from the older protocol. So updating the fixtures to the latest signatures should resolve the issue. Any recommendations on how to generate the signatures in the test/fixtures file?
marypreethi12 commented
i fixed some typo errors which were failing CI, however now we have 3 tests failed 11 passed, is it something to do with signature which @davebryson mentioned ?