`grid_max` should return the last grid point rather than the upper bound of the interval for `includeendpoint=false`
Opened this issue · 2 comments
shinaoka commented
If includeendpoint=false
, grid_max
should return the last point of the grid, rather than the supremum.
We could introduce grid_supremum
returning b
for
shinaoka commented
I got my head around this point. supremum
is mathematically correct, but sounds unfamiliar. How about the following.
- Rename the attributes of
DiscretizedGrid
asgrid_max
->upper_bound
andgrid_min
tolower_bound
. grid_max
function returns the last grid point.- We introduce
upper_bound
andlower_bound
functions.
shinaoka commented
@rittermarc
I have a draft now. Does it make sense?
https://github.com/tensor4all/QuanticsGrids.jl/tree/7-invalid-grid_max-for-includeendpoint%3Dfalse