bug: recent changelog loses some commits
kemingy opened this issue · 3 comments
kemingy commented
The recent two changelogs lose some PRs. (comparing to release changelog generated by go-releaser)
- https://github.com/tensorchord/envd/releases/tag/v0.3.25 vs #1651
- https://github.com/tensorchord/envd/releases/tag/v0.3.26 vs #1654
Can you help check the script? @terrytangyuan
Originally posted by @kemingy in #1654 (comment)
terrytangyuan commented
Sure I'll check
terrytangyuan commented
That's expected since we didn't want to include doc changes in release notes. Release notes should be user-facing and less verbose. Let me know if you have any other thoughts on this. https://github.com/tensorchord/envd/blob/main/hack/changelog.sh#L12
kemingy commented
That's expected since we didn't want to include doc changes in release notes. Release notes should be user-facing and less verbose. Let me know if you have any other thoughts on this. https://github.com/tensorchord/envd/blob/main/hack/changelog.sh#L12
Make sense. Then I think the dependabot PRs should also be excluded. WDYT?