tensorchord/openmodelz

dev: replacing agent dep to local path make it not able to install by `go install`

zwpaper opened this issue · 7 comments

mdz replace agent to parent dir ../agent, this is convenient for local develop, but make it not able to install by go install.

how about using the full URL when upload intree, and create a make local-build to change it locally.

replace github.com/tensorchord/openmodelz/agent => ../agent

https://github.com/tensorchord/openmodelz/blob/main/agent/go.mod#L7-L8

can you assign It to me and help me proceed with this issue to resolve it ... @zwpaper

SGTM, I think this works.

@zwpaper Could you please help with this issue?

of cause, how about we do it this way: @gaocegege

  1. add a Make command, build-local, it check the local deps in go.mod, build directly if local deps existed; comment out the 3 deps, add local deps then build if no local deps found.
  2. make build should make sure there are no local deps, and then build.
  3. add docs for local-build and build
  4. add docs for go install

@cybergeekgyan feel free to start implement after we on the same page with @gaocegege

@cybergeekgyan Already picked 2 issus up. Could you please help with this issue? @zwpaper

Yeah I think we are on the same page.

ok, I will fire a PR later today

Could we close this? @zwpaper