tensorflow/cloud

Performance issues in /src/python/tensorflow_cloud/core (by P3)

DLPerf opened this issue · 3 comments

DLPerf commented

Hello! I've found a performance issue in /tests/testdata/keras_tuner_cifar_example.py: batch() should be called before map(), which could make your program more efficient. Here is the tensorflow document to support it.

Detailed description is listed below:

  • .batch(BATCH_SIZE)(here) should be called before train_dataset.map(scale)(here).
  • .batch(BATCH_SIZE)(here) should be called before .map(scale)(here).

Besides, you need to check the function called in map()(e.g., scale called in .map(scale)) whether to be affected or not to make the changed code work properly. For example, if scale needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z).

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

DLPerf commented

Hello, I'm looking forward to your reply~

sharmadhiraj86 commented

I would like to contribute in solving this issue. Can you please assign this issue to me? @DLPerf @lamberta @mihaimaruseac @jaeyounkim @martinwicke

mihaimaruseac commented

We don't generally assign issue to contributors. Instead, please send a PR when ready.