terkelg/eliminate

Remove sync version?

lukeed opened this issue ยท 2 comments

This looks almost exactly like one of my internal tools ๐Ÿ˜†

I would maybe suggest that since you're shipping code with async syntax, that there's no/little point in shipping a sync version of the code.

This is because having async (and fs.rmdir) in the code at all, even when not imported, forces a Node 7.6+ environment, wherein native async is available.

So, anyone using this lib can/should have an async parent function that awaits this guy. You'd only be dropping support for top-level usage, which is easily fixed anyway.

Agree fd44c02 removes the sync version. ๐Ÿ‘

Nice~! ๐ŸŽ‰