terminal42/deployer-recipes

Automatically detect the location of parameters.yml file

Closed this issue · 3 comments

bd804f8

This is actually without functionality atm because the symfony recipe already sets the shared_files variable in https://github.com/deployphp/deployer/blob/74b3f73e60acee2eccc0d53c270a7c4335d5b5a7/recipe/symfony.php#L24.
I changed to the symfony4 recipe and it looks fine.

Proposal:
Change from symfony to symfony4 recipe in the bootstrap file.

In addition, we need to adjust the deploy:platform_release task to choose the correct parameters.yml file.

Does it change anything if symfony4 recipe also explicitly sets the shared files?

https://github.com/deployphp/deployer/blob/74b3f73e60acee2eccc0d53c270a7c4335d5b5a7/recipe/symfony4.php#L13

Well, the symfony4 recipe is parsed before our symfony recipe (load order).
This means, symfony4.php sets the shared_files (i.e. .env) and symfony.php adds the parameters.yml correspondingly.

This got fixed in 97f0dbf and c9530d4.