terraform-aws-modules/terraform-aws-dms

Ignore_headers_row changed to ignore_header_rows

Johnyang12345 opened this issue · 16 comments

Johnyang12345 commented

Hi,

In main.tf line 269:
ignore_headers_row = lookup(s3_settings.value, "ignore_headers_row", null)

ignore_headers_row was changed to ignore_header_rows in https://registry.terraform.io/providers/hashicorp/aws/4.65.0/docs/resources/dms_endpoint

Thanks,
John

Deleted user commented

This is related to this change hashicorp/terraform-provider-aws#26957 which has been closed in Jan 5th, 2023. Can someone help to fix it? Thanks!

  • 👍4
nimish commented

Is there a maintainer available on this project? @antonbabenko this is a necessary fix for this module to work with aws >= 5

bryantbiggs commented

There are a few changes we need to make to support v5.0 of the AWS provider. Until we make those changes in a breaking change (major version) for this module, you can pin the version of the provider that you use to < 5.0

nimish commented

There are a few changes we need to make to support v5.0 of the AWS provider. Until we make those changes in a breaking change (major version) for this module, you can pin the version of the provider that you use to < 5.0

Hmm, we cannot do this. We'll have to fork this with a temp fix in the meantime.

igorjanevski commented

Up!
Please fix this, we are stuck with the issue!

DodgeCamaro commented

Up

  • 👎1
tiagoflino commented

Up!

antonbabenko commented

This issue has been resolved in version 2.0.0 🎉

  • ❤️2
brunodasilvalenga commented

Really appreciate it @antonbabenko

github-actions commented

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.