`desired_size` on eks node-group shouldn't be ignored during the lifecycle of an aws_eks_node_group
DanMaxic opened this issue · 8 comments
desired_size on eks node-group shouldn't be ignored during the lifecycle of an aws_eks_node_group
it is a deliberate design decision in order to support the predominant use of scaling services like cluster autoscaler, Karpenter, etc.
This creates a problem if you are not using any form of autoscaling. For example, my cluster has 3, 6, and 9 for the values of min, desired, and max respectively. I am adjusting the terraform in order to double my clusters capacity. Now I am getting an error that the minimum cannot be larger than desired when using this module.
I believe as a workaround I can go and adjust the desired by hand in the console but that defeats the purpose of using terraform.
we cannot parameterize the lifecycle/ignore_changes block so unfortunately we have taken the direction to ignore desired size changes since this is how the vast majority of users utilize the module
Perhaps there could be a different node group type? eks_managed_no_autoscaling_node_groups or something similar?
not in this module, no - we are doing everything we can currently to avoid any additional complexity overhead. the next breaking change at v19.x will actually remove the custom ASGs and launch templates so we can offload that to our https://github.com/terraform-aws-modules/terraform-aws-autoscaling module
Okay, I'll wait to see what those changes entail. Thanks for the feedback.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.