terraform-aws-modules/terraform-aws-vpc

support for multipe public route tables

pedrojflores opened this issue · 9 comments

Is your request related to a new offering from AWS?

Yes. This is to better support a vpc hosting an AWS Firewall infrastructure where you need to route traffic from public subnets to an unique firewall interface on a specific az.

Is your request related to a problem? Please describe.

Yes. Due to this limitation I can't use this module to build my AWS Firewall Egress vpcs.

Describe the solution you'd like.

I would like an option that when set a unique route table gets created per public subnet (per az). Same support the module has for private subnets.

add support for adding routes to public and private subnets.

@pedrojflores I have created a pull request, please let me know if this is what you were looking for, and we can wait for a review.
#1025

Feliz año 2024!

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

Pumping up this issue as it is not stale anymore

I've also created a pull request that expands this to both public and intra subnets: #1051

I punted on the other subnet types as their logic was a bit more complex, but it should be possible to support multiple route tables for all subnet types.

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

Not stale

This issue has been resolved in version 5.8.0 🎉

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.