terraform-google-modules/cloud-foundation-training

04-Instance-Group: Fix Service Account Typo

mbachari opened this issue · 3 comments

In main.tf and iam.tf we reference the service account as
sa-cft-training@${var.project_id}.iam.gserviceaccount.com
It should be
cft-training@${var.project_id}.iam.gserviceaccount.com
without sa- as in the 00-Setup lab and subsequent labs

@mbachari I believe we are moving towards sa-cft-training, and we should fix 00-Setup lab to create sa-cft-training instead of cft-training. Happy to accept a PR if you have bandwidth :)

sounds good, let met get through all the labs and then I'll submit a PR after making sure no broken references are there

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days