Unable to deploy newer versions of Helm chart due to hardcoded, since-updated Helm configuration keys

[Jberlinsky]

TL;DR

Breaking Helm chart updates have moved configuration of gitlab.task-runner to gitlab.toolbox

Expected behavior

Successful provisioning of Gitlab

Observed behavior

Invoking the module yields an error:

│ Error: execution error at (gitlab/templates/NOTES.txt:141:3): 
│ DEPRECATIONS:
│ 
│ gitlab.task-runner:
│     The configuration of `gitlab.task-runner` has been renamed. Please use `gitlab.toolbox` instead.
│     If you have enabled persistence for `task-runner` and/or its CronJob for backups, you may need to manually bind the new `toolbox` PVC to the previous `task-runner` PV.
│ 
│   with module.gke-gitlab.helm_release.gitlab,
│   on .terraform/modules/gke-gitlab/main.tf line 389, in resource "helm_release" "gitlab":
│  389: resource "helm_release" "gitlab" {

Terraform Configuration

module "gke-gitlab" {
  source = "terraform-google-modules/gke-gitlab/google"

  project_id                 = module.project-gitlab.project_id
  region                     = "us-central1"
  certmanager_email          = "REDACTED"
  domain                     = "REDACTED"
  gitlab_db_random_prefix    = true
  gitlab_deletion_protection = true

  gke_machine_type = "n2-standard-4"
  gke_version      = "1.24.2"

  gitlab_nodes_subnet_cidr    = "10.0.0.0/23"
  gitlab_pods_subnet_cidr     = "192.168.0.0/18"
  gitlab_services_subnet_cidr = "192.168.128.0/23"

  helm_chart_version    = "6.3.3"
  gitlab_runner_install = true
}

Terraform Version

1.2.1

Additional information

No response

[Jberlinsky]

Worth pointing out that moving to the default helm_chart_version with gke_version = 1.24.2 yields other errors (deprecated resources in the hardcoded API references)

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days