why such a trivial example?
symbiont-ji opened this issue · 3 comments
symbiont-ji commented
The example shows nothing. A better example would how how to specify overrides to the default helm chart.
bharathkkb commented
Hi @symbiont-ji
Thanks for the feedback, we generally tend to have 1 simple example that shows how to invoke the module with defaults and we also use for it for testing the module. Happy to review any PRs for additional examples that showcase advanced usecases.
symbiont-ji commented
What is the point of providing a module if you also do not say how to use
it? As for testing, a trivial example that does not exercise every
component of the module does not count as testing!
/ji
…On Fri, Nov 13, 2020 at 9:52 PM Bharath KKB ***@***.***> wrote:
Hi @symbiont-ji <https://github.com/symbiont-ji>
Thanks for the feedback, we generally tend to have 1 simple example that
shows how to invoke the module with defaults and we also use for it for
testing
<https://github.com/terraform-google-modules/terraform-google-gke-gitlab/tree/master/test>
the module. Happy to review any PRs for additional examples that showcase
advanced usecases.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#67 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFTEDSUAVTI2YESZAYOGMDSPXWGXANCNFSM4TVH23NA>
.
symbiont-ji commented
I guess you do not care about the quality of your documentation, right?