terraform-google-modules/terraform-google-lb-internal

Add region in google_compute_network / subnetwork

ocervell opened this issue · 2 comments

On the subnetwork datasource, we should add the region parameter: indeed, if it is unset in the provider, the module will fail to run:

Screenshot 2019-11-13 at 18 39 20

However, setting it in the provider is not always the right thing to do (if you work with multiple regions for instance), and it would be nice to be able to pass it explicitely to the datasource.

Can we please add a region variable ?

There's already a region variable, so it would be a simple matter of adding it to the data source.

PR welcome.

The region variable had already been added in the #16 via the commit dcaf3aa