terraform-google-modules/terraform-google-network

ingress and egress replacing firewall rules breaks existing code

sanspace opened this issue · 1 comments

          This did break complaining about the variable type for something that was already working on 7.2.0. We might wanna bump it to 8.0 after confirming the breaking behavior. @bharathkkb  @imrannayer 
Error: Invalid value for input variable
│ 
│   on ../../modules/vpc/[main.tf](http://main.tf/) line 9, in module "network_vpc":
│    9:   firewall_rules = var.firewall_rules
│ 
│ The given value is not suitable for module.vpc[1].module.vpc.module.network_vpc.var.firewall_rules declared at
│ .terraform/modules/vpc.vpc.network_vpc/[variables.tf:73](http://variables.tf:73/),1-26: list of object required.

We were passing a local var below for the firewall_rules value:

   xxxxx_firewall_rules = {
    allow-icmp = {
      name        = "xxxxx-allow-icmp"
      description = null
      direction   = "INGRESS"
      priority    = null
      ranges = [
        "0.0.0.0/0"
      ]
      source_tags             = null
      source_service_accounts = null
      target_tags             = null
      target_service_accounts = null
      allow = [{
        protocol = "icmp"
      }]
      deny = []
      log_config = {
        metadata = "INCLUDE_ALL_METADATA"
      }
    }
  }

Originally posted by @sanspace in #485 (comment)

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days