terraform-google-modules/terraform-google-service-accounts

Allow per-SA descriptions

roscoejp opened this issue · 3 comments

SA descriptions should allow for list format similar to names so that each uniquely created SA can have a unique description. The current module only allows one description for all service accounts.

Yes, this seems like a reasonable addition. I will put it on the backlog and would be happy to review a PR if someone wants it sooner.

I'll get working on this later today or tomorrow and'll have a PR out for y'all. I assume there's no problem with the variable type change (string -> list) as long as the module version gets updated?

@roscoejp I suggest we actually add this as a new descriptions variable which will override the description if provided, so this change is backwards-compatible (and simpler).