Support network_ip on additional_networks

[steven-edgar]

TL;DR

Support network_ip block in additional_networks when instance count > 1

Terraform Resources

No response

Detailed design

In the current module version it is impossible to set fixed IP addresses using the network_ip block in additional_networks if your instance count is >1. This is because the additional_networks[].network_ip is defined as a string, whereas it needs to be a list of strings to support this scenario.

I would suggest that the line in modules/umig/main.tf, line 76 should be 
`network_ip         = length(network_interface.value.network_ip) > 0 ? network_interface.value.network_ip[count.index] :null`

and in modules/umig/variables.tf change the definition to
`network_ip = list(string)`

access_config.nat_ip suffers from a similar issue. 

Obviously changing the variable type from string to list(string) is a breaking change, but introducing a new variable in the additional_networks block, such as "network_ips", is similarly breaking.

Additional information

No response

[morgante]

Have you seen the static_ips input? What are you trying to do that this wouldn't accomplish?

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days