terraform-ibm-modules/terraform-ibm-base-ocp-vpc

"zone" terminology is confusing and misleading

vburckhardt opened this issue · 1 comments

The prefix at https://github.com/terraform-ibm-modules/terraform-ibm-base-ocp-vpc/blob/main/variables.tf#L59 use the "zone-X" terminology. This is very prone to error as could be interpreted as "availability zones" when this actually denotes logical zones (segregation by subnet).

In fact, it seems that the examples are getting into this confusion - see #95

The default in the root module for worker_pools variable does not make sense either - as it is making assumptions on prefix on the subnets passed at https://github.com/terraform-ibm-modules/terraform-ibm-base-ocp-vpc/blob/main/variables.tf#L34

PR merged. Closing issue