terraform-ibm-modules/terraform-ibm-landing-zone-vpc

Add logic to create flow logs in terraform-ibm-landing-zone-vpc module

vburckhardt opened this issue · 2 comments

vburckhardt commented

Description

The flow log creation logic conceptually belong to this VPC module.
The logic is currently located in the landing-zone module (at https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/blob/main/main.tf#L39)

The objective of this ticket is to:

  1. Move the flow log logic to this VPC module
  2. Update the references in the landing-zone module

New or affected modules

  • terraform-ibm-landing-zone-vpc
  • terraform-ibm-landing-zone

By submitting this issue, you agree to follow our Code of Conduct

maheshwarishikha commented
  1. Move the flow log logic to this VPC module - Completed and merged.
  2. Update the references in the landing-zone module - code changes are done, not merged. Blocked by other issue (4190)
  • 👍1
ocofaigh commented

Tracking the second part of this in SLZ repo terraform-ibm-modules/terraform-ibm-landing-zone#403 and closing this issue as all the dev work for VPC flow log logic has been completed in this module