Please support custom headers
dhirschfeld opened this issue · 17 comments
Community Note
- Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
- Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
- If you are interested in working on this issue or have submitted a pull request, please leave a comment
Description
Custom headers were added in azure cli in Azure/azure-cli-extensions#1104.
It would be great if terraform allowed passing through custom headers.
My particular usecase is selecting Ubuntu 18.04 for AKS:
https://docs.microsoft.com/en-au/azure/aks/cluster-configuration#os-configuration-preview
is there some way of passing this through before its fully supported?
As well as Ubuntu 18.04 I'd also like to test all of the below which require the ability to pass custom headers:
xref: #7947
Interesting/relevant? comment in the AKS repo:
We'll be making a few additional options so you're able to try these previews that don't land on the API via ARM too. Stay tuned on the next few weeks.
Hi.. do we have any updates for adding custom header?
Do we have an update on aks-custom-headers support? We have a use-case for enabling UltraSSD's as part of our provisioning:
--aks-custom-headers EnableUltraSSD=true
I'm also looking for an update on this issue. Deploying AKS version 1.18.8 using Terraform still deploys Ubuntu 16.04. Looking for an option to deploy AKS version 1.18.8 with Ubuntu 18.04.
At least for the OS disk type, it has been implemented in #9166.
https://docs.microsoft.com/en-us/azure/aks/csi-secrets-store-driver, storage CSI drivers are GAed but not availbe in terraform to enable it
@tombuildsstuff Hey Tom, after checking this comment and checking the source code, it seems like the solution for this is to include these properties into the actual request headers for the create cluster operations. Would the solution be similar to what you did for appconfiguration here?
I ask as I would love to get this working for the storage CSI drivers that went GA but require a special request header to enable the feature that can only be enabled on the cluster creation request.
Im happy to try to get it working, but I don't have any experience with working directly on terraform source code so if some one more experienced wants to work on the solution happy to let them do so.
For the benefit of anyone tracking this issue @aristosvo PR was Closed with status wontfix. There was a valid reason for this and the suggestion was too request these Headers to be added to the Swagger for the AKS API. I have subsequently created an issue on the AKS project.
Opened a PR on the Swagger repository to add support for this, FWIW: Azure/azure-rest-api-specs#18232
Any update on this? Trying to set --aks-custom-headers UseGPUDedicatedVHD=true is a blocker to properly implement this: https://learn.microsoft.com/en-us/azure/aks/gpu-cluster if we don't want to manually deploy the Daemonset.
Tom's PR was closed as AKS are moving away from using custom headers. Given that, I'll close the issue for support here.
@dhirschfeld is there any place where this deprecation of using custom headers is notified/written? At least to find which is the alternative Azure is suggesting instead of the headers and get an idea when will we be able to use GPU machines in AKS from terraform without hacks...
The linked issue has the current status. I'm not fully clear how/if preview features will be supported by terraform in future :/
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.