FluidBox opens surrounding link (href) when image is opened in Firefox 41.0.2
aramin opened this issue · 7 comments
Yesterday I updated FluidBox from 1.4 to 2.0 and realized that in Firefox 41.0.2 the link of an image is opened after the image was clicked. I could hotfix that behavior with a e.stopPropagation() (directly after e.preventDefault()) in line 524.
If you need stop event propagation to stop an image from opening, it suggests that there's something else on your page that is muddling up Fluidbox behavior. Are you listening to a click event propagation higher up the DOM tree?
Also stopping event propagation would break a lot of things if implemented. For example, what if a user is listening to a bubbling click event to perform a silent AJAX request? That'll be rendered non-functional if we choose to stop events from bubbling up.
Helpful tip: try using your markup in the packaged demo, and see if you can reproduce the issue.
Thanks for the rapid response! 👍
I also tried the demo-page and experienced the same behaviour (e.g. when I click on the single image http://terrymun.github.io/Fluidbox/demo/index.html#single-image). So I would assume that it's not related to my code/DOM-structure.
I am unfortunately unable to replicate your issue on v41 and v42 of Firefox tho.
On 07 Nov 2015, at 10:33, aramin notifications@github.com wrote:
Thanks for the rapid response!
I also tried the demo-page and experienced the same behaviour (e.g. when I click on the single image http://terrymun.github.io/Fluidbox/demo/index.html#single-image http://terrymun.github.io/Fluidbox/demo/index.html#single-image). So I would assume that it's not related to my code/DOM-structure.—
Reply to this email directly or view it on GitHub #151 (comment).
Maybe it's a Windows-only issue. I just tried it with FF 42 and im still facing the problem. I'll test it on monday on an OSX system.
The system where the error occured is as following:
Windows 8.1 Pro
Firefox 42.0
I have tested the demo page using BrowseStack, on both Windows 7 and 8 and OS X El Capitan and Yosemite, with FF v41. Still unable to reproduce your issue.
Do you have some plugins/addons that are installed on your browser that might potentially interfere with Fluidbox functionality? Ad-blockers, content filters and the likes, perhaps?
Ok, I just tried it on a Mac with OSX Yosemite FF 42.0 and everything works like a charm.
The problem is caused by the addon "AS Magic Player". So everything is fine and I'm sorry for the inconvenience.