terrymun/Fluidbox

White Flash

Closed this issue · 6 comments

louy commented

There's a white flash when closing the Fluidbox that flashes twice.
The first is while scaling down the image and the other is after the image is closed.
I think this happens when switching between the two image sizes but the effect is really ugly.

I am aware of that issue. If (you think) it is ugly and affecting you tremendously, you are free to edit the code yourself. It's not on the top priority list to fix now.

louy commented

I'm not able to solve this right now, but it should be very simple.
Just switch positions of 268 and 270. I believe this solves at least one of the flashes.
https://github.com/terrymun/Fluidbox/blob/master/jquery.fluidbox.js#L268

I'm not using the code yet. I'm just trying to help.

Sometimes, there are more polite ways of phrasing the issue. I am maintaining this plugin in my free time amidst a very busy PhD schedule (which isn't even remotely related to programming), so a bit of appreciation and kindness will get you a long way — not only on here, but other places on the Internet, too.

Just saying.

louy commented

Sorry that you felt that way, Your implementation is really nice, and I am just trying to help make it better. I wouldn't bother myself reporting issues on something that isn't worth it.

The issue has been fixed, by listening on to transitionend event and waiting for transitions to be completed before fading images.

louy commented

Nice, one of the flashes is now gone. Thanks.