tesselle/tabula

FrequencyMatrix

soodoku opened this issue · 3 comments

It took me a bit to realize that FrequencyMatrix doesn't carry frequencies. It is actually CountMatrix that carries the frequencies. This is a small semantic point. Frequency = number of times X occurs. I know you define Frequency' as RelativeFrequency' but plausibly an argument that relabel Count as Frequency and Frequency as RelFrequency.

your call. not a blocker.

The way these two classes are named was a headache when the package was created. My original idea was to avoid having classes with relatively similar names, but you're right, it was at the expense of the meaning of names.

In the end, the FrequencyMatrix class is not very useful. In the short term I will leave things as they are and I think I will rename (remove?) this class in a future release.

got it. just close it out.

or add to a future to do list or something that you get to when you want to.