testcontainers/testcontainers-python

Investigate what to do about "localnpipe" on windows

alexanderankin opened this issue · 1 comments

it has been some time. the urllib3/docker-py incompatibilities are fixed. the time of using named pipes on windows is here. the question is how to deal with them in this library. for now, i am suggesting a fix like:

class DockerContainer:
    # ...
    def get_container_host_ip(self) -> str:
        # ...
        # see https://github.com/testcontainers/testcontainers-python/issues/415
        if host == "localnpipe" and "Windows" == system():
            return "localhost"
        # ...

but it really should get investigated in the short term.