latest svelte@5 broke its tests

Question

latest svelte@5 broke its tests

yanick opened this issue 5 months ago · 6 comments

yanick commented 5 months ago

see #352

Answer 1 · 2024-04-18T17:15:08.000Z

Reported to the mothership, in case it could help: sveltejs/svelte#11228

Answer 2 · 2024-04-18T20:06:09.000Z

Weirdly enough, I cannot reproduce this failure locally on the same Svelte version

❯ npm why svelte
svelte@5.0.0-next.108 dev

I wonder if there's a race condition here? Maybe tick() isn't fully flushing updates, and that's what CI is hitting

Answer 3 · 2024-04-19T20:03:21.000Z

More testing results:

svelte@5 accessor tests pass with @sveltejs/vite-plugin-svelte@3.0.2
svelte@5 accessor tests fail with @sveltejs/vite-plugin-svelte@3.1.0

Will add this to the thread over in svelte, too

Answer 4 · 2024-04-19T20:06:08.000Z

Oh hm mothership issue has been closed with a fix that "preserves accessors with HMR." That's odd, because we have HMR disabled in our test suite. Will wait on the next.109 release though and see what happens

Answer 5 · 2024-04-20T15:03:45.000Z

@yanick looks like this has, in fact, been fixed upstream. Your report did the trick. I can no longer repro locally nor in CI

Answer 6 · 2024-04-20T15:34:09.000Z

W00t! That was easy. ^.^