testing-library/testing-library-docs

"Testing Library and React Router v5" example uses React Router v6 API

sonngdev opened this issue · 3 comments

sonngdev commented

Describe the bug

The Testing Library and React Router v5 example uses the location and navigator props of <Router />, which only exist in React Router v6. In v5, the only relevant prop is history (reference). I will open a PR to fix this.

Screenshots

Screen Shot 2022-07-09 at 15 44 42

sonngdev commented

Closing since submitted PR is merged

  • 👍1
MatanBobi commented

Thanks @thanhsonng!
Next time, writing "Resolves #issue number" will automatically link the issue and close it :)

sonngdev commented

@MatanBobi I thought linking it from the right sidebar was the only way, which I couldn't do without permission. Thanks for the tip!

  • 👍1