testing-library/testing-library-docs

Missing const

morgan121 opened this issue · 5 comments

morgan121 commented

Looks like line 19, 20 and 22 of this file are missing the word const? meant the example errored when I tried to test it locally

testing-library-docs/docs/example-input-event.mdx

Line 19 in 8acaf6e

removeDollarSign = value => (value[0] === '$' ? value.slice(1) : value)

MatanBobi commented

Looks like you're right :) want to create a PR?

morgan121 commented

happy to. to do that do I just clone the repo and then push a branch? never contributed to someone elses repo before

  • ❤️1
MatanBobi commented

You'll first need to fork the repo and then clone your fork 🙂 I recommend taking a quick look at this course

morgan121 commented

ok, seems like a bit more work. will try and look later if i get time

morgan121 commented

ok - PR is here, think I did it right? #1223