testing-library/testing-library-docs

Add AngularChallenges into angular framework example section

tomalaforge opened this issue · 6 comments

tomalaforge commented

I am the maintainer of Angular Challenges , and I have a series of challenges on TestingLibrary with Angular.

I think it would be helpful for people to have access to those challenge though the example section inside Angular framework section in the document, under Tim repository.

What do you think ?

MatanBobi commented

As a general idea, we don't like to link to other pages where we don't have maintenance responsibility because they can become outdated but I'll leave it to @timdeschryver to decide :)

tomalaforge commented

I understand. I will wait for @timdeschryver to answer. 😊

timdeschryver commented

I think we can add it here https://testing-library.com/docs/learning ?
It would also be OK to add a note in the README of the examples within the Angular repo - https://github.com/testing-library/angular-testing-library/blob/main/apps/example-app/src/app/examples/README.md

The challenges seem to be broader then just testing, is there a way to make the testing section "pop" out because that's what our users are looking for. Or maybe add a testing page that we can refer to?
With the current state it's hard to discover the testing section.

tomalaforge commented

Yes I understand what you are saying. AngularChallenges cover multiple part of Angular and testing is only one part of it.

I can create a testing.README.md where all testing challenge will be shown. And we can link to that page. Will this be ok ?

And what about this section: https://testing-library.com/docs/angular-testing-library/examples#more-examples? Don't you think it doesn't fit here? It covers some aspects that you show inside your repository, but it also includes different examples.

tomalaforge commented

HI @timdeschryver,

I have created a readme file gathering only testing challenges: https://github.com/tomalaforge/angular-challenges/blob/main/README.test.md

timdeschryver commented

@tomalaforge to stay consistent with the other pages of the website, I still think it would be better to add it to the learning page https://testing-library.com/docs/learning (I also link the name challenge to learning).
Feel free to add the test readme to the learning page https://testing-library.com/docs/learning.