testshallpass/react-native-dropdownalert

Constant exports is breaking react-native-web

Closed this issue · 1 comments

Short Description

Constants being exporter in constants.js causing react-native-web to break

Errors...

Screen Shot 2019-09-11 at 11 16 43 PM

Steps to Reproduce / Code Snippets / Usage

Try to use DropdownAlert in a project with react-native-web

Expected Results

react-native-web projects should not crash

Additional Information

  • React Native version: 0.59.8
  • react-native-dropdownalert version: ^4.1.1
  • Platform(s) (iOS, Android, or both?): react-native-web
  • iOS version: N/A
  • Android version: N/A
  • React Native Web version: ^1.0.0-alpha.9

Solution

Change the constants.js from....

module.exports = {
  DEFAULT_IMAGE_DIMENSIONS,
  WINDOW,
  HEIGHT,
  WIDTH,
  IS_IOS,
  IS_ANDROID,
  IS_IOS_BELOW_11,
  TYPE,
  ACTION,
  getDefaultStatusBarStyle,
  getDefaultStatusBarBackgroundColor,
};

to this

export {
  DEFAULT_IMAGE_DIMENSIONS,
  WINDOW,
  HEIGHT,
  WIDTH,
  IS_IOS,
  IS_ANDROID,
  IS_IOS_BELOW_11,
  TYPE,
  ACTION,
  getDefaultStatusBarStyle,
  getDefaultStatusBarBackgroundColor,
};

fixes the issue

@BillyFigueroa This relates to #204 which has been fixed in 4.2.0.