tfoxy/chrome-promise

Consider remove requirement of creating object

amio opened this issue · 3 comments

amio commented

Since there's no option for new ChromePromise(), how about let user directly use window.ChromePromise or import cp from 'chrome-promise'?

amio commented

Oops, my mistake, there is an option object >.<

tfoxy commented

There is an options object. But most people using this library will never use the options.

So I think it's better to provide an instance of ChromePromise as default and if someone wants to use the constructor, then it can be imported from 'chrome-promise/constructor'.

I can make the changes on the weekend.

tfoxy commented

Fixed in 797b0af (v3.0.0)