tg12/FAIG

Epic pricechange/spread error?

FlickeringIRoam opened this issue · 1 comments

FAIG/faig.py

Line 203 in 3e577ec

if Price_Change_Day_percent < 0.48 and Price_Change_Day_percent < 1.9 and Price_Change_Day_percent < -0.48 and Price_Change_Day_percent > -1.9:

is actually the same as:
if Price_Change_Day_percent < -0.48 and Price_Change_Day_percent > -1.9:

I don't necessarily know the logic behind it, but I suspect this should be:
if (Price_Change_Day_percent > 0.48 and Price_Change_Day_percent < 1.9) or (Price_Change_Day_percent < -0.48 and Price_Change_Day_percent > -1.9):
to pick up buys OR sells

If not, it can be simplified to the above 2 conditions.

tg12 commented

As discussed, Think we have this one fixed.