FlexFiltResetMenu / FlexFiltResetMon Cleanup
Opened this issue · 6 comments
Can IsInstr be removed? Have "freq" in menu automatically turned off when the filter is called as an instrument?
If so, FlexFiltResetMenu can be made into an instr
Remove strcat(SChanPrefix,)... this is now a global only widget!
Got rid of all of the SChanPrefix and strcats.
Made all calls to FlexFiltInstrHide have no chan name, removed unneeded versions of UDO with chan names.
Changed order of FlexFiltVis options to remove ambiguity for overloaded arguments... this fixes issues with instrument filters not initializing properly.
New format:
FlexFiltVis (optional iIsInstr), "SChanPrefix", (optional iMenuArray[])
Warning Popup now has bug where if triggered by second filter, it can not be dismissed. (if possible, calling the warning from the first filter makes it work again)... probably a chnset "threading" style issue to look into.
Alternate option, rip out the warning entirely. Not really needed anymore? Rezzy was fixed a long time ago, and most filters seem stable anyway... (:thinking_face:)
Oh, also important to note: removed FlexFiltInstrHide entirely. FilterReset widget will always allow freq toggles, even in instrument mode... JUST IN CASE a user wants to use both instr mode and effect mode.
Warning panels have been removed entirely.
FlexFilt and FlexFiltFull have been rewritten to do the mixing of audio inside the UDO for easier use.
Needs a little more cleanup (instruments and manual versions still need work), but other than some basic documentation, filters are almost ready to go...
Filters have been mostly "cleaned up and checked in. Still needs cleanup for manual and instrument versions, but effects versions seem ready to go.
Still leaning open for now... but BIG progress has been made
And because Effects are good to go, no longer an Alpha issue... moving to Beta.