th0rgall/fullscreen

Shortcut not working in Chrome & Edge on Windows & Linux

MarkTiedemann opened this issue · 1 comments

MarkTiedemann commented

First of all, thanks for the awesome fork! :)

As documented in the Chrome keyboard shortcuts article, pressing Ctrl+Shift+o opens the Bookmarks Manager on Windows and Linux (chrome://bookmarks/ or edge://favorites/) - rather than toggling the fullscreen. If you set the shortcut explicitly via chrome://extensions/shortcuts or edge://extensions/shortcuts, it works fine, however.

PS: Would you like to join forces to improve this extension?

th0rgall commented

Hey @MarkTiedemann! First of all, happy to see you're still active on this :)

Some answers

PS: Would you like to join forces to improve this extension

Sure! I'll make a PR back to your repo so we can fix stuff there.

pressing Ctrl+Shift+o opens the Bookmarks Manager on Windows and Linux

That's important, thanks for noting. As you probably figured I only used it on a macOS here. Which shortcut do you think would be better?

chrome://extensions/shortcuts

Yep, I figured that one out too, but it took me some time to find. Completely unintuitive for users as it is not available through the settings...

I was going to add this link in the extension description (below)

Chrome store version

I saw you have about 73 active users on Firefox now (that's where I found yours), but it seems unreleased on Chrome (?). So I published the extension on the Chrome Web Store here.

I spent some time making banners/writing a description for that, because there wasn't one on your Firefox version. See here for the materials.

Since there are a lot extension that seem to do the same in the Chrome extension store, I differentiated this one by saying that it is:

  1. minimal (which it is, also super small)
  2. safe (no unnecessary permissions, open-source)
  3. does real fullscreen without titlebars (with requestFullscreen)

Next steps

To keep to the promises above, I don't think much more should happen to this extension now, except:

  1. Fixing the shortcut as you note here.
  2. For now this version actually doesn't work in Firefox. It's due to a bug I documented here
    Workaround: still use the <all_urls> permission on Firefox this doesn't work, there is no workaround in Firefox. I'll open a new bug here too.