thanhluu/Yelp

[Assignment 2] Review

Opened this issue · 0 comments

thanhtan1105 commented

+1: Nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints.

This was a challenging assignment, congrats on completing it successfully!

Grading Summary:

  • Functionality: Excellent
  • Code Style: Excellent
  • Visual Design: Excellent
  • Usability: Good

Overall: Excellent

Detailed Notes

  • You should comment function if not use, check remove all warning before commit
    screenshot 2017-03-05 01 23 12

  • Nice work specifying the Auto Layout constraints. To rotate the simulator you can use Cmd-Left Arrow or Cmd-Right Arrow. Rotating the screen is a great way to see if you set up your constraints properly. Also try on small screen to easily screen out the autoLayout error.

  • Nice work linking the filter model with the controls. See this popular form library for an alternative to implementing forms manually.

  • Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.

Great job dedicating enough time to do the homework. You learned a lot! Keep up the good work.