`Button` with `Outline` variant should respect the `ButtonColor` prop
Closed this issue · 2 comments
The ButtonColor prop doesn't seem to work when using other variants such as Outline.
In the case of outline, the text color should perhaps be influenced by the button color prop. So <Button variant=ButtonVariant::Outline color=ButtonColor::Primary>"Hello"</Button> should have a blue text for the button.
A good example of this would be the official Thaw UI website's navigation not indicating the current page.
In the screenshot above, I'm on the Thaw UI "Guide" page, however the button does not indicate this. It would make sense for this to be blue as suggested in this issue.
https://www.naiveui.com/en-US/os-theme/components/button#secondary.vue
https://www.naiveui.com/en-US/os-theme/components/button#quaternary.vue
Like this?
I feel that this will be a breakthrough change and we can implement it in 0.4. It won't be long, as lepots0.7-alpha should be released soon.
Given that the v0.4 release already follows the Fluent design specification, I'll close this issue.