`ServerBanSynchronisationProtection` seems to be unable to detect ACL is out of date when a server policy has been removed
Opened this issue · 1 comments
Gnuxie commented
Reported by @TheArcaneBrony
Context: https://matrix.to/#/%21IaWNErZAgQUhGqJXjX%3Amatrix.org/%24yG1FbGtkJqE-hYRgp17q-XwRDQ4HgvdqvJrIS1GOBwQ?via=matrix.org&via=envs.net&via=ubuntu.com
My suspicion is that the Mjolnir era code that tests this has been changed or broken subtily, but it should be easy to find out by reproducing policy removal.
https://github.com/Gnuxie/matrix-protection-suite/blob/main/src/MatrixTypes/ServerACLBuilder.ts#L99-L127
https://github.com/matrix-org/mjolnir/blob/main/src/models/ServerAcl.ts#L104-L134
TheArcaneBrony commented
Keep in mind this happened after this flow:
- Remove policies, one by one, in bulk (eg. via Nheko)
- Restart draupnir once finished to prevent flooding protected rooms with consecutive ACL updates