Wrong check for the size of things to put in the jar
Opened this issue · 5 comments
Line 3780 of file things.zil has the order of the arguments reversed. The correct syntax is
(<G? <GETP ,PRSO ,P?SIZE> 1>
What does the "invalid" label mean?
The description in the list of labels is “This doesn’t seem right”.
If the report cited a symptom observed while playing the game, I’d have used the bug label which has the description “Something isn’t working”.
In my view, it refers to the source code, not the issue.
So, to cut a long story short, “invalid” is for code reviews and “bug” is for tests.
OK, so I guess what you need is an explanation of the buggy behavior? This code is supposed to stop you from putting things in the jar that are too big, or destroy something that's small enough to fit but not the circlet. As it is, interpreters such as Bocfel crash with an invalid property error.
Only if you intended to make a test report. I’m happy with the code review.