the-markup/blacklight-collector

Replace "page.waitFor" with "page.waitForTimeout"

johansmith90 opened this issue · 2 comments

Running await.collector currently causes a depreciation warning from puppeteer to be logged to the console every time waitFor is called with puppeteer@5.2.1.

waitFor is deprecated and will be removed in a future release. See puppeteer/puppeteer#6214 for details and how to migrate your code

Replacing page.waitFor with page.waitForTimeout in the following files should remove this depreciation warning:

  • src/pptr-utils/interaction-utils.ts
  • src/collector.ts
  • tests/key-logging.ts

Happy to submit a PR if you're accepting them.

Thanks, yeah I noticed this when I upgraded to 5.2.1, will fix on the next release

Fixed in #30. Thanks for the report!