the-orange-alliance/toa-angular-old

API - team json - "zip code" is string not always a number

lancelarsen opened this issue · 1 comments

"zip code" is string not number
In the api models, "zip code" is listed as being a "number" - but at least one value coming back in json is non-numeric as our json deserializer complained about zip - so there must be a non-numeric in the data set. Believe that the model docs just need to be updated.

{"team_key":"18599","region_key":"MO","league_key":null,"team_number":18599,"team_name_short":"OFHS Team 5","team_name_long":"Orchard Farm High School","robot_name":null,"last_active":"2021","city":"Saint Charles","state_prov":"MO","zip_code":"63301","country":"USA","rookie_year":2020,"website":null}

Looks like the only values not coming back in quotes that we see in the json are "team_number" and "rookie_year"

This may have something to do with not all "postal codes" from FIRST for all countries are numbers. I'll have to check the data and how we store it in the DB, but this is definitely not right.