[Bug] Light mode does not persist on title page after refresh

Question

[Bug] Light mode does not persist on title page after refresh

travisk-codes opened this issue 4 years ago · 6 comments

travisk-codes commented 4 years ago

Description:
When light mode is enabled, refreshing the title page will revert it back to dark mode.

To Reproduce:

Enable light mode
Navigate back to the title page
Refresh the page

Expected Behavior:
Light mode to persist after refresh

Environment:

OS: 5.8.6-arch1-1
Browser: Firefox 80.0.1 (64-bit)
Browser: Chromium 85.0.4183.83 (64-bit)

Answer 1 · 2020-09-08T11:03:56.000Z

The issue seems to happen on every layout, part of the layout doesn't take account the localStorage value:

https://theprogrammershangout.com/resources/javascript/

Answer 2 · 2020-09-08T20:52:00.000Z

I am able to reproduce on prod, but not on develop master. Are you?

prod steps: light mode -> refresh -> switches to dark mode with black text
dev steps: light mode -> refresh -> stays in light mode

Answer 3 · 2020-09-08T22:10:18.000Z

I'm feeling like it's related to statically generated generated Gatsby assets

Answer 4 · 2020-09-08T22:12:27.000Z

yes 100%: https://joshwcomeau.com/gatsby/dark-mode/ improved solution from what we have

Answer 5 · 2020-09-08T23:02:39.000Z

I'll look into it--does it look like a major overhaul?

Answer 6 · 2020-09-09T13:59:06.000Z

No we have the majority of the groundwork already for it, it's mainly injecting some JS at runtime before Gatsby runs which is covered by the article.