pycrypto module requirement
Qazeer opened this issue · 7 comments
Hello!
Is the pycrypto
module still required (as specified in the install_requires
)?
The pycrypto
project is no longer maintained and causes issues for standalone build on Windows (due to incompatibility with recent VS build tools).
I haven't seen any usage of pycrypto
in the code after a quick glance and it is no longer required by impacket
(#485). I removed the requirements and could successfully setup pywerview
as well as call a few submodules.
If pycrypto
is required, would it be possible to replace it by pycryptodome
(a good transparent replacement with the same namespace / functions)?
Hi!
Yes you are right, I think we need to clean up the setup.py
file to match requirements.txt
. I'll try to fix (and test!) this soon.
🌻
Hey!
As you probably saw, I pushed a fix for this issue in develop
. I'm not familiar with dependency management but I think it's ok now.
🌻
Hi!
Thank you 👍
Hello @ThePirateWhoSmellsOfSunflowers
Can you also push it to master and push it to pip ? This is a blocking point for us to generate the docker image.
Thanks :)
Salut 😄 !
I'm currently away from keyboard but I'll take a look.
🌻
Hi all! We're back from vacation and we were able to push the new release to PyPI. Hope this helps!
In case crypto functions are still needed, use pycryptodome
instead of pycrypto
.