the-via/firmware

Add support to configure TAPPING_TERM of mod-tap / tap-hold

Opened this issue · 2 comments

lesca commented

Hello,
I am glad to become a user of this project. I am reading a lot of docs to configure my keyboard Keycron Q10.
I find a very good feature of QMK - [mod-tap] (https://docs.qmk.fm/#/mod_tap)

However, this is a little bit buggy with VIA. I configure space to MT(MOD_LCTL, KC_SPC). This works fine when I type slowly, but if I type quickly, the space is lost and become ctrl + <next_key_I_typed>. this is very annoying and make it hard to use.

I figured out there is one option for [tap_hold] (https://docs.qmk.fm/#/tap_hold) - TAPPING_TERM.
I think this issue can be resolved by adjusting this option. However, I cannot find any place to configure this. I neither didn't find anything useful from VIA's doc.

Please check this and add support to configure it if possible!

Regards,
Lesca

lesca commented

Hello,
I turned to rebuild the firmware with changes on below files:

// keyboards\keychron\q10\ansi_encoder\config.h
#define TAPPING_TERM 250
// keyboards\keychron\q10\ansi_encoder\rules.mk
DYNAMIC_TAPPING_TERM_ENABLE  = yes	# Enable Dynamic Tapping Term

and set the keycodes by Any key with Hex keycodes:

// quantum\keycodes.h
QK_DYNAMIC_TAPPING_TERM_PRINT = 0x7C70,
QK_DYNAMIC_TAPPING_TERM_UP = 0x7C71,
QK_DYNAMIC_TAPPING_TERM_DOWN = 0x7C72,

Image

This is a so-called dynamic tapping term feature introduced in QMK
doc: [tap-hold] (https://docs.qmk.fm/#/tap_hold)

Please consider to support the key definitions in the web app.
key definitions: [Dynamic Tapping Term] (https://docs.qmk.fm/#/tap_hold?id=dynamic-tapping-term)

Please allow Tapping Term to be configured via the web app.