theKashey/react-focus-lock

React 18 support limited by transitive dependency

billyjanitsch opened this issue · 2 comments

Hi! I see that 2.9.0 was released with the changelog noting React 18 support.

Unfortunately, the library technically isn't compatible with React 18 because it depends on react-clientside-effect@^1.2.5, which doesn't permit React 18 as a peer dep. This means that recent versions of npm will refuse to install react-focus-lock alongside React 18.

I see that you're also the owner of react-clientside-effect, so this should be an easy fix. I've submitted a PR there (theKashey/react-clientside-effect#5) to add React 18 to peer deps. If you merge that and release react-clientside-effect@1.2.6, then upgrade the dependency in react-focus-lock to react-clientside-effect@^1.2.6 and release react-focus-lock@2.9.1, that will resolve the issue.

Thanks!

theKashey/react-clientside-effect#5 has been released (v1.2.6).
react-focus-lock update is waiting for theKashey/focus-lock#36 to be resolved....

Released as 2.9.1