thebjorn/pydeps

Setup installs requires python <3.4, even if python 3.8 is supported

Closed this issue · 2 comments

In setup.py:

    install_requires=[
        'enum34; python_version < "3.4"',
        'stdlib_list',
    ],

But version pydeps>=1.9.0 is supposed to support python 3.8 according to the changelog:

Version 1.9.0 supports Python 3.8.

I would like to use pydeps with python 3.8, but dependencies resolution fails according to which is required :(

Is it only a oversight in setup.py ? In this case, it should be changed :)

Hi Paul, you've misunderstood what that line means. It says that if your Python version is less than Python 3.4, then pydeps also requires the enum34 package. If your Python version is 3.4.0, or higher, then the enum34 package is not needed (because enums are built-in after py3.4). It doesn't say anything about which Python version you can install pydeps on - it just says what else needs to be installed (or not) depending on which python version you have.

If you install pydeps on Python 3.8:

(py38test) go|c:\srv> python -V
Python 3.8.6

(py38test) go|c:\srv> pip list
Package    Version
---------- -------
pip        20.3.1
setuptools 51.0.0
wheel      0.36.1
WARNING: You are using pip version 20.3.1; however, version 21.0.1 is available.
You should consider upgrading via the 'c:\srv\venv\py38test\Scripts\python.exe -m pip install --upgrade pip' command.

(py38test) go|c:\srv> pip install pydeps
Looking in indexes: https://pypi.org/simple, http://pypi.norsktest.xyz
Collecting pydeps
  Using cached pydeps-1.9.13.tar.gz (41 kB)
Collecting stdlib_list
  Using cached stdlib_list-0.8.0-py3-none-any.whl (63 kB)
Building wheels for collected packages: pydeps
  Building wheel for pydeps (setup.py) ... done
  Created wheel for pydeps: filename=pydeps-1.9.13-py3-none-any.whl size=41318 sha256=86125f8de3d16fde598ef44149d03af347d1617ea1bca497ef29aa7744f3810d
  Stored in directory: c:\users\bp.datakortet\appdata\local\pip\cache\wheels\bb\4c\5c\e9e3a7817906019f695cad5503beecd9515759dfa603f25adf
Successfully built pydeps
Installing collected packages: stdlib-list, pydeps
Successfully installed pydeps-1.9.13 stdlib-list-0.8.0

You will note in the last line that pydeps and stdlib-list have been installed.

If you install pydeps on Python 2.7:

(py27test) go|c:\srv> python -V
Python 2.7.17

(py27test) go|c:\srv> pip list
Package    Version
---------- -------
pip        20.3.4
setuptools 44.1.1
wheel      0.36.2

(py27test) go|c:\srv> pip install pydeps
Looking in indexes: https://pypi.org/simple, http://pypi.norsktest.xyz
Collecting pydeps
  Downloading pydeps-1.9.13-py2-none-any.whl (42 kB)
     |███████████████████████████████ | 40 kB 1.1 MB/s eta     |████████████████████████████████| 42 kB 217 kB/s
Collecting enum34; python_version < "3.4"
  Using cached enum34-1.1.10-py2-none-any.whl (11 kB)
Collecting stdlib-list
  Downloading stdlib-list-0.8.0.tar.gz (82 kB)
     |████████████████████████████    | 71 kB 1.1 MB/s eta 0:00:     |████████████████████████████████| 81 kB 1.1 MB/s e     |████████████████████████████████| 82 kB 255 kB/s
Processing c:\users\bp.datakortet\appdata\local\pip\cache\wheels\c2\ea\a3\25af52265fad6418a74df0b8d9ca8b89e0b3735dbd4d0d3794\functools32-3.2.3.post2-py2-none-any.whl
Building wheels for collected packages: stdlib-list
  Building wheel for stdlib-list (setup.py) ... done
  Created wheel for stdlib-list: filename=stdlib_list-0.8.0-py2-none-any.whl size=63542 sha256=5931c520c26ab152403f28ef2343b822798254814ca05a9863d9d99d5ce4e4a6
  Stored in directory: c:\users\bp.datakortet\appdata\local\pip\cache\wheels\21\18\19\6acbe4c85fd12f7b5793543aafdb7ce1dd0d192d3e8a103556
Successfully built stdlib-list
Installing collected packages: enum34, functools32, stdlib-list, pydeps
Successfully installed enum34-1.1.10 functools32-3.2.3.post2 pydeps-1.9.13 stdlib-list-0.8.0

You will note that enum34, functools32, pydeps, and stdlib-list have been installed (I'm assuming, without checking, that functools32 comes from enum34's setup.py file).

My bad, I read too quickly. I try to figure out why my nox session always downgrade my python from 3.8 to 2.7, but you're right it's not from here. I close this issue.