Symlinks are ignored

Question

Symlinks are ignored

aaronjensen opened this issue 4 years ago · 8 comments

aaronjensen commented 4 years ago

Ideally, symlinks would be followable or this would be an option. At the moment, they are completely ignored:

https://github.com/thecodrr/fdir/blob/master/src/api/shared.js#L48-L54

This appears to be causing this downstream issue in snowpack: FredKSchott/snowpack#2969

aaronjensen commented 4 years ago

Thanks!

👍1

Answer 1 · 2021-03-31T17:02:17.000Z

I am working on symlink support however it will affect performance greatly. It will be out and about soon though as an option withSymlinks probably.

Answer 2 · 2021-03-31T17:16:56.000Z

That's great, thank you.

Answer 3 · 2021-03-31T20:58:09.000Z

Just found this lib and I'm really interested in symlink support too! Any ETA on when can we expect it?

Answer 4 · 2021-04-01T15:11:26.000Z

@DominikLevitsky I can't give an ETA but it is in the works. The main issue is implementing it safely and in a performant way. I will be posting updates here so hang on tight, it will be out in the next version for sure.

Answer 5 · 2021-04-16T17:54:42.000Z

I am working on symlink support however it will affect performance greatly. It will be out and about soon though as an option withSymlinks probably.

Would it still "affect performance greatly" if the root directory is a symlink? ...as opposed to starting a real directory but possible symlinks within.

Answer 6 · 2021-04-16T19:56:50.000Z

@peterbe no, the performance penalty is only for symlink resolution. Afterwards, fdir will operate normally. I have a basic PoC ready which i'll be pushing for testing soon.

Answer 7 · 2021-04-18T10:26:54.000Z

Symlinks support is almost done. Just have to benchmark the performance impact when withSymlinks is not there.