[Feature] glob/crawl by symlink path, not real path

Question

[Feature] glob/crawl by symlink path, not real path

IanVS opened this issue 2 years ago · 8 comments

As noted in #23 (comment), currently globs match against resolved symlink paths, not the symlink paths themselves. This is a bit counter-intuitive, and I think that the symlink paths should be matched and returned instead, perhaps with an option to return real paths instead.

Answer 1 · 2022-10-18T13:15:44.000Z

WIP at #84

Answer 2 · 2022-10-18T13:25:01.000Z

@IanVS can you test against master branch and see if that works for you?

Answer 3 · 2022-10-18T14:18:29.000Z

Yep, I copied over the src from master and it's now working correctly! Thanks!

Answer 4 · 2022-10-18T14:50:14.000Z

Will release v5.3.0 then

Answer 5 · 2022-10-18T17:44:37.000Z

@IanVS done. I changed the API a bit to be backwards compatible with v5 so check the docs to see how you can use it.

Answer 6 · 2022-10-18T17:52:34.000Z

Thanks. One small piece of unsolicited feedback, is that this might fall into the boolean trap. When reading .withSymlinks(false) it could reasonably be thought that symlinks are disabled. An API like .withSymlinks({ resolve: boolean }) gives a bit more clarity, IMHO. But, that's just my own two cents. Thanks again for getting this released so quickly!

Answer 7 · 2022-10-18T17:56:50.000Z

One small piece of unsolicited feedback, is that this might fall into the boolean trap.

I agree. I'll be making some breaking changes in v6.0 so this API is definitely not final. There's a lot of confusion in the current exposed methods so I will do some much needed renaming as well.