Nothing happens
Opened this issue · 2 comments
I have tried your demo and the only response is navigating to the /healthcheck endpoint but there is no data on the success or failure. It would be nice if it showed a result for each health check defined and the appropriate status.
I've also put this into an ASP.NET API with the same results.
But something does change. The status code transitions from OK to Unavailable on a health-check error. You can also query the /healthcheck
end point with the debug
flag to provide more information about failing health checks.
I, personally, do not like having text in my healthcheck endpoint. On a failure, I want to know something is wrong but my tool for diagnosing what is wrong is typically detailed logs. The more information you put in a health-check response to try and diagnose a problem the more information you potentially leak to the outside world - that is, if your healthcheck endpoint is public.
Hi @thedillonb I came across this issue after about 2 hours of trying to work out why nothing was working. I understand your design decisions, but please would you update the documentation on the front page to indicate that only HTTP status codes are returned?
Also, when you say use the "debug flag", it's not totally clear that you're referring to a query string key/value "debug=true", so it would be beneficial to add this, too.
Thanks very much for the effort you've put in to this - it's a very useful component.