thefactory/marathon-python

YAML support for marathon-cli

Closed this issue · 4 comments

navidurrahman commented

I need a marathon-cli with YAML support. Should I add the functionality and open a pull request?

Previously, I opened a pull request of chronos-python, but looks like asher is away these days.

solarkennedy commented

Yea, I think it wouldn't be that much feature creep to have a CLI, but I would be very skeptical if it did any more than just post the yaml contents. It will be a lot of upkeep if we have to constantly add a billion cli arguments.

navidurrahman commented

I agree with you in a way, but look at the example below, and let me know your thoughts.

./bin/marathon create -y apps/apps.yaml -d ubuntu/image:tag -e env_file
- id: uae-celery
  cpus: 0.65
  mem: 2048
  cmd: "sleep 100"
  volumes:
    - container_path: "/home/user/logs/"
      host_path: "/var/log"

We are trying to separate data files from code, and it can be useful from any admin machine.

Regarding multiple arguments, i guess few functions should be fine.

solarkennedy commented

Seems fine, I think it is just important to know what we are committing to. As long as we are clear that the api bindings are the first class citizen here. I can easily imagine this command line tool growing into like, a full paas....

If you want to ensure that this continues to work as this package evolves, I encourage you to write at least one itest that, so that we will know if it breaks in the future.